Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add marginRight and flex<Box/> to prevent text/button overlap #1455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add marginRight and flex<Box/> to prevent text/button overlap #1455

wants to merge 1 commit into from
+21 −17

Conversation

mateoclarke
Copy link
Contributor

@mateoclarke mateoclarke commented Oct 14, 2024 •
edited
Loading

Associated issues

Fixes cityofaustin/atd-data-tech#17689

Before

Screenshot 2024-06-05 at 5 48 43 PM

After

Screenshot 2024-10-14 at 4 13 34 PM

Testing

URL to test:
https://deploy-preview-1455--atd-moped-main.netlify.app/moped/projects/2037?tab=map

Steps to test:

  1. Look at the existing components and confirm the Component name text does not overlap with the Zoom In Icon.
  2. Create a new component with a long name (ex: a traffic signal like 25: MLK & Congress).

Ship list

johnclary
johnclary approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@johnclary johnclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make my location descriptions as long as I please! Very nice to see flex box come to the rescue 🚢 🚢 🚢 🚢 🚢

chiaberry
chiaberry approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@chiaberry chiaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-16 at 1 41 46 PM

Thank you for addressing this! such an unsightly bug ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiaberry chiaberry chiaberry approved these changes

@johnclary johnclary johnclary approved these changes

@mddilley mddilley Awaiting requested review from mddilley

@tillyw tillyw Awaiting requested review from tillyw

@frankhereford frankhereford Awaiting requested review from frankhereford

@roseeichelmann roseeichelmann Awaiting requested review from roseeichelmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bug where project component list item location descriptions overlap the zoom-to-feature button
3 participants
@mateoclarke @chiaberry @johnclary