Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance eventtype filtering in eventlistings with a drop-down #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thoni56
Copy link
Contributor

@thoni56 thoni56 commented Jan 4, 2024

This incorporates the simple change in #64 and adds selection based on names of event types.

This incorporates the simple change in civicrm#68 and adds selection based on
names of event types.
@aydun
Copy link
Contributor

aydun commented Feb 21, 2024

Thanks - I tried this locally but just get a text box for event type, not the dropdown:
image

@thoni56
Copy link
Contributor Author

thoni56 commented Feb 21, 2024

Have you ensured that the copy of eventlisting.xml in components/com_civicrm/views/Events/tmpl is also updated?

I'm not sure why the files in components need to be there, but it looks to me that, since those copies are not in this repo, they are copied from administrator/... on installation. Unless there is some action during build of the civicrm bundle that I could not find.

Anyway, without the changes also in components/..., what ever XML-definition is there will be used.

At least I hope that is the cause for your installation not picking it up.

Also, I would very much appreciate if you could help me out with how I could test this locally? This repo will not build into a normal Joomla extension that can be installed, and I haven't managed to figure out how to integrate this with a complete CiviCRM build either. So I hacked the sources of an existing install and then extracted those changes to create this PR. Would appreciate any and all help with doing that the correct way.

@thoni56
Copy link
Contributor Author

thoni56 commented May 29, 2024

INSTRUCTIONS for testing:

Copy either the modified files or the contents of the site subdirectory to the corresponding directory under BOTH components/com_civicrm AND administrator/components/com_civicrm/civicrm/joomla/site. E.g.

cp -r .../civicrm-joomla-repo/site/* htdocs/components/com_civicrm/
cp -r .../civicrm-joomla-repo/site/* htdocs/administrator/components/com_civicrm/civicrm/joomla/site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants