Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for create pool #343

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix for create pool #343

merged 1 commit into from
Sep 19, 2023

Conversation

alessandroargentieri
Copy link
Member

Create pool fails because still using the PUT /v2/kubernetes/clusters/{id} endpoint.
This MR implements the client for the new endpoint POST /v2/kubernetes/clusters/{id}/pools for creating new pools.

Already tested in production on the real case which was failing.

alejandrojnm
alejandrojnm approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@alejandrojnm alejandrojnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we need to do the same in terraform, I can do it

@alessandroargentieri alessandroargentieri merged commit 1df0ac9 into master Sep 19, 2023
1 check passed
@alejandrojnm alejandrojnm deleted the fix-create-pool branch September 19, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrojnm alejandrojnm alejandrojnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessandroargentieri @alejandrojnm