-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getThemePath()
fails when a generated package is located in a mono-repo
#132
Labels
squad:devops
Issue to be handled by the Devops team.
type:bug
This issue reports a buggy (incorrect) behavior.
Comments
pomek
added
squad:devops
Issue to be handled by the Devops team.
type:bug
This issue reports a buggy (incorrect) behavior.
labels
Dec 2, 2022
The same applies to ckeditor5-package-generator/packages/ckeditor5-package-tools/lib/utils/get-webpack-config-dll.js Lines 30 to 31 in 8f40903
Fix: // An absolute path to the manifest file that the `DllReferencePlugin` plugin uses for mapping dependencies.
const ckeditor5manifestPath = require.resolve( 'ckeditor5/build/ckeditor5-dll.manifest.json' ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
squad:devops
Issue to be handled by the Devops team.
type:bug
This issue reports a buggy (incorrect) behavior.
π Provide detailed reproduction steps (if any)
yarn start
βοΈ Expected result
It does not throw any errors.
β Actual result
β Possible solution
package.json
file fromnode_modules/
insideckeditor5-foo
.ckeditor5-package-generator/packages/ckeditor5-package-tools/lib/utils/get-theme-path.js
Lines 22 to 23 in 8f40903
The text was updated successfully, but these errors were encountered: