Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the repository to ESM and use the latest ckeditor5-dev-* #192

Open
pomek opened this issue Sep 27, 2024 · 3 comments · May be fixed by #196
Open

Convert the repository to ESM and use the latest ckeditor5-dev-* #192

pomek opened this issue Sep 27, 2024 · 3 comments · May be fixed by #196
Labels
squad:devops Issue to be handled by the Devops team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pomek
Copy link
Member

pomek commented Sep 27, 2024

Provide a description of the task

This issue is a continuation of #191.

We want to use the upcoming release (PR) of ckeditor5-dev-* packages. Unfortunately, it requires converting packages from this repository to ESM, but it also needs aligned CKEditor 5 code (PR).

Definition of Done

  • Packages located in this repository are marked as ESM.
  • The ckeditor5-dev-* packages are used in their latest versions.
  • CI is green.
@pomek pomek added squad:devops Issue to be handled by the Devops team. type:task This issue reports a chore (non-production change) and other types of "todos". labels Sep 27, 2024
@pomek
Copy link
Member Author

pomek commented Sep 27, 2024 •
edited by psmyrek
Loading

Current blockers

@psmyrek
Copy link
Contributor

psmyrek commented Sep 30, 2024

Branch with conversion of this repository to ESM: ci/3772 (master...ci/3772).

@pomek
Copy link
Member Author

pomek commented Oct 3, 2024

We can use CKEditor 5 nightly releases to verify if our changes follow a good path. Unfortunately, we can merge them right after the next CKEditor 5 release, which is not scheduled yet. Hence, let's keep them on a feature branch. We will go back to this topic later.

@psmyrek psmyrek linked a pull request Oct 3, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
squad:devops Issue to be handled by the Devops team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Converted the package to ESM ckeditor/ckeditor5-package-generator
2 participants
@pomek @psmyrek