Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaml-rust to 0.4.3 #1541

Closed
wants to merge 1 commit into from
Closed

Update yaml-rust to 0.4.3 #1541

wants to merge 1 commit into from

Conversation

ki-dof
Copy link

@ki-dof ki-dof commented Sep 3, 2019

Version 0.3.5 Vulnerable
chyh1990/yaml-rust#109
Uncontrolled recursion leads to abort in deserialization

@JohnTitor
Copy link
Contributor

Could you resolve the conflict?

@Dylan-DPC-zz
Copy link

This has already been fixed in 3.0 candidate.

@JohnTitor
Copy link
Contributor

Hmm, latest master uses 0.4 and the version range can be >=0.4.0 <0.5.0. But the fixed version is 0.4.1 so it's better to specify the patch version?

@Dylan-DPC-zz
Copy link

@JohnTitor that should be fine, it will mostly pick the latest version. We don't need to pin it to a single version

@CreepySkeleton
Copy link
Contributor

rust-yaml = "0.4.1" will not pin it to a single version but rather to ">= 0.4.1" which is exactly what we want. Reopening.

@CreepySkeleton CreepySkeleton reopened this Feb 1, 2020
@Dylan-DPC-zz
Copy link

No it won't. Versions bounds are ^ by default so "0.4.1" is equivalent to "^0.4.1

@CreepySkeleton
Copy link
Contributor

CreepySkeleton commented Feb 1, 2020 via email

@Dylan-DPC-zz
Copy link

Nevermind. Both of us are saying the same thing.

@pksunkara
Copy link
Member

pksunkara commented Feb 1, 2020

Fixed by #1651

@pksunkara pksunkara closed this Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants