-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shorthandCompacting: background not merging properly with -[webkit|moz|o]-linear-gradient #509
Comments
@collinsethans Thanks for raising this issue. I'm currently at the point of rewriting compacting code so will definitely look at it soon. |
@jakubpawlowicz Thanks for acknowledging, it will be great to have these fixed. I am currently using this on production, will you have a ballpark timeline by when you may have the new code released? Another feature that I was thinking will help much here is if there's some log on what gets compacted and/or optimized to what. That will give us a lot of confidence when using in production. (The above bug went unnoticed and was pointed by an user after a week of release). Will you have any plans on adding such logging feature? |
I plan to release 3.2 in 1-2 weeks from now, as I'm nearing completion of internals rewrite. Interesting idea about the log. It could be rather verbose unless we'd narrow it to something like shorthand compacting only. |
@jakubpawlowicz Hi, thanks for the timeline. Yes, the logs will be very verbose, but then it's easier to validate the output and issue identification is quick, thus builds confidence. And, it will run only with a switch, non-default. To begin with, it can be for anything and everything that the tool is going to optimize in the file. |
@collinsethans let's see what can be done here. It would need to provide a list of optimizations made to properties and selectors, which won't be straightforward to add. I've opened #514 to cover it. |
Fixed in master with #490. |
I have the below css for transparent facebook logo on a gradient:
Using shorthandCompacting, the above is reduced to:
Due to this, the fb logo is not shown on several browsers.
I have current work-around by setting shorthandCompacting: false.
The text was updated successfully, but these errors were encountered: