Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-markdown to render static pages instead and consolidate the React and Markdown files into one file #113

Closed
swyxio opened this issue Jan 24, 2018 · 1 comment

Comments

@swyxio
Copy link

swyxio commented Jan 24, 2018

as spoken via research call

https:/thinkmill/react-markings also uses CommonMark so we have full compatibility with the existing markdown flavor used in Pup, but this time it can be done purely within React so there is no preprocessing phase required. Less files, less lines of code. Also a nice bonus, we can inject code into the page with this method so it becomes less "static" than before.

@swyxio swyxio changed the title Use react-markings to render static pages instead and consolidate the React and Markdown files into one file Use react-markdown to render static pages instead and consolidate the React and Markdown files into one file Feb 10, 2018
@swyxio
Copy link
Author

swyxio commented Feb 10, 2018

i am changing this to use react-markdown as it has better OSS support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants