Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add Style Components #133

Closed
wants to merge 7 commits into from

Conversation

toinevk
Copy link
Contributor

@toinevk toinevk commented Mar 7, 2018

A long time user and fan of pup and its predecessor, I thought I should contribute! This PR refactors to move away from SCSS to styled components, a first step towards out of the box SSR. Addresses #81.

Key Notes:

  • Create Custom Form Group to implement bootstrap overrides (f4a101f)
  • Add Babel plugin for styled components required for SSR
  • Remove SCSS files and packages
  • Used InjectGlobal to attach styles to html and body in the footer component. This is not recommended by styled components authors, as part of the layout refactor I believe this can refactored (i.e. to a full page layout with 100% min height).
  • All styles have been put into the component files.

Outstanding Questions

  • Remove the files out of the folders given they are redundant?
  • Refactored content component and pages to what I think the intended outcome should have been? The content component looked duplicated. Let me know if that should be undone (
    3a23638)

cleverbeagle and others added 7 commits March 4, 2018 12:04
Add packages and set up theme and media breakpoints per style
components guide.
Migrate Components, remove some duplicated SCSS from Application.scss.
Need to revisit injectGlobal in footer.
Create custom form group to apply current override SCSS styles.
Remove sass files. Refactor app to destructure classname so it doesn’t
get passed down to Navigation and other components.
@cleverbeagle
Copy link
Owner

Hey @toinevk thanks for your work on this. We'll likely do this in house, but if you're interested in being involved in that effort send me an email: [email protected].

@toinevk toinevk closed this May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants