Abbreviated repeated names in a Clojure function name #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After demangling strips off the numeric suffix from a Clojure function name,
in cases where you have deeply nested anonymous functions (say, because you are
using nubank/state-flow) you can with a long name of repeated `/fn/fn/fn..` values; this change reduces those repeats down to `/fn{x14}` (the actual
count).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After demangling strips off the numeric suffix from a Clojure function name, in cases where you have deeply nested anonymous functions (say, because you are using nubank/state-flow) you can end up with a long name of repeated
/fn/fn/fn..values; this change reduces those repeats down to/fn{x14}(the actual count, 14).Using curly braces looks about right, and won't collide with just about any Clojure or Java identifier.