Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of download_directory_as_zip function for NC31 #304

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

bigcat88
Copy link
Contributor

In 31 Nextcloud, the old method of downloading folders has simply been removed.

The changes are very useful, downloading a folder through webdav has become more pleasant, and now we can download it in tar format, something like this:

   nc.files.download_directory_as_zip("test_empty_dir_in_dir", "2.tar", format="x-tar")

Default usage doesn't changed, so no something breaking for nc_py_api usage.

References:

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.82%. Comparing base (8386eb9) to head (82efad2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   94.81%   94.82%           
=======================================
  Files          46       46           
  Lines        5346     5354    +8     
=======================================
+ Hits         5069     5077    +8     
  Misses        277      277           
Files with missing lines Coverage Δ
nc_py_api/_session.py 96.47% <100.00%> (ø)
nc_py_api/files/files.py 100.00% <100.00%> (ø)
nc_py_api/files/files_async.py 100.00% <100.00%> (ø)

@bigcat88 bigcat88 merged commit fabe8ea into main Sep 29, 2024
19 checks passed
@bigcat88 bigcat88 deleted the fix/nc31-download_as_zip branch September 29, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant