Adding the Provider #1
Conversation
fabi200123
commented
Feb 16, 2024
fabi200123
commented
- Adding the OCI External Provider
- Update README.md
fabi200123
force-pushed
the
WIP
branch
2 times, most recently
from
b315de8
to
1add837
Compare
| } | ||
|
|
||
| func (o *OciProvider) DeleteInstance(ctx context.Context, instanceID string) error { | ||
| return o.ociCli.DeleteInstance(ctx, instanceID) |
There was a problem hiding this comment.
Delete should work by name or ID. Is the name also the ID?
There was a problem hiding this comment.
No, added the functionality to work for both (same for GetInstance)
There was a problem hiding this comment.
Generally speaking, it's wise to maintain architectural boundaries. The DeleteInstance() function from the client should deal only with removing instances. The name implies the purpose and the OCI API does not expect an instance name. The DeleteInstance() from the provider is known to take either a provider ID, or in the case of a failure, we send the instance name in a last ditch attempt at cleanup.
In future releases, we will definitely differentiate between the 2 in the DeleteInstance() function of the provider, but for now, the resolution of the name to ID should happen in this function, not in the one defined in the client.
internal/spec/spec.go
Outdated
| if err != nil { | ||
| return nil, fmt.Errorf("failed to generate userdata: %w", err) | ||
| } | ||
| wrapped := fmt.Sprintf("<powershell>%s</powershell>", udata) |
There was a problem hiding this comment.
Does this work on OCI? I was under the impression they were using cloudbase-init.
There was a problem hiding this comment.
It works, but it is not needed. It works without as well, updated the code.
| } | ||
| } | ||
|
|
||
| func (r *RunnerSpec) SetUserData() error { |
There was a problem hiding this comment.
Whenever you have a Set() function that changes a value in a struct, it's a good idea to put it behind a mutex to prevent race conditions. In that case you'll also need a Get() function that also tries to lock the mutex.
func (r *RunnerSpec) SetUserData() error {
r.mux.Lock()
defer r.mux.Unlock()
// rest of code goes here
}
