Created some nice assertions for events #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
slinkydeveloper
force-pushed
the
nice_assertions
branch
from
78e5f6f
to
acd167f
Compare
Signed-off-by: Francesco Guardiani <[email protected]>
|
This looks nice. I'd definitely like to see this go in. There may be some more predicates we want later, but they are easy to add even by external callers by just implementing the interface, so I'm good with what's there. |
Sure, or we can add them here, so they can be beneficial for all users |
n3wscott
approved these changes
Jun 2, 2020
slinkydeveloper
added a commit
that referenced
this pull request
Jun 8, 2020
* More assertions Signed-off-by: Francesco Guardiani <[email protected]> * Moar assertions Signed-off-by: Francesco Guardiani <[email protected]> * Changed ContainsAttributes signature Signed-off-by: Francesco Guardiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's an initial list of assertions, we can add more of them later
Signed-off-by: Francesco Guardiani [email protected]