-
Notifications
You must be signed in to change notification settings - Fork 81
npm test fails without running npm run build #104
Comments
Yea, that's because tests don't use aliasing (or webpack) but they are using symlinks that are created by However, as far as you work on one component and its tests at the time you don't need to rebuild. Only if you are trying update tests let's say for cf-component-link and changing source of cf-util-route-handler since cf-util-route-handler is a dep of cf-component-link. It's quite an edge case. It doesn't even happen with UI components since they don't link each other. I think it makes sense.
Yea, it should be updated. You can also see it in
I think it nukes only node_modules, so you you should be fine only with |
@tajo you are right, |
updated README.md as part of Yarn migration. |
before PR was landed, this worked:
npm install
npm run bootstrap
npm test
now we have to run 3 steps before running test:
npm install
npm run bootstrap
npm run build
npm test
I assume it was an intended behavior, on the other hand, we should reflect it in the README and CONTRIBUTING docs. I also think we could move aliasing step outside of the build step and run it within
npm run bootstrap
.Another note, after running
npm run clean
we need again 2 extra steps before able to run tests:npm run bootstrap
npm run build
npm test
The text was updated successfully, but these errors were encountered: