Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding rule for constant values #478

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Adding rule for constant values #478

merged 1 commit into from
Feb 14, 2024

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Feb 10, 2024 •
edited
Loading

  • fix threshold for constant values.
  • go mod tidy inside the /asm folders.

@armfazh armfazh added the cosmetic readability an cleanliness of code label Feb 10, 2024
@armfazh armfazh self-assigned this Feb 10, 2024
bwesterb
bwesterb reviewed Feb 10, 2024
View reviewed changes
group/group_test.go Outdated Show resolved Hide resolved
@armfazh armfazh changed the title Adding constant values and removing hardcoded private key. Adding rule for constant values Feb 14, 2024
@armfazh armfazh merged commit b6d2926 into cloudflare:main Feb 14, 2024
10 checks passed
@armfazh armfazh deleted the fixConstPkey branch February 14, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lekensteyn Lekensteyn Lekensteyn left review comments

@mmcloughlin mmcloughlin mmcloughlin left review comments

@bwesterb bwesterb bwesterb approved these changes

Assignees

@armfazh armfazh

Labels
cosmetic readability an cleanliness of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armfazh @bwesterb @Lekensteyn @mmcloughlin