Upper case all http methods in fetch API with compat flag #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
changed the title
anonrig
approved these changes
Oct 11, 2024
jasnell
commented
Oct 11, 2024
|
Up to you but personally I'd be in favor of not bothering with a compat flag here and just making the change for everyone. It only turns an error case into a non-error case and I can't imagine why anyone would be probing for this error. |
kentonv
reviewed
Oct 11, 2024
|
I'd prefer the compat flag if only to provide a means of reverting back to the more strict spec-compliance mode. I'm not a fan of intentionally moving away from the spec requirements without at least providing a safety hatch. |
This introduces a non-standard behavior to uppercase *all* HTTP methods in fetch requests rather than just the limited set defined by the standard. Fixes: #2516
jasnell
force-pushed
the
jsnell/uppercase-all-http-methods
branch
from
2e443f5
to
077a0a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a non-standard behavior that would become the default. Please review carefully. See the original bug report for context (linked below).
Fixes: #2516