Remove direct eval in pyodide.asm.js #2934
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
force-pushed
the
dlapid/fix_setupEmscripten_build_warnings
branch
from
ad09d2e
to
f8a44be
Compare
|
Problem with previous PR was actually the minify sadly. |
|
These |
danlapid
changed the title
hoodmane
approved these changes
Oct 16, 2024
danlapid
force-pushed
the
dlapid/fix_setupEmscripten_build_warnings
branch
2 times, most recently
from
bcc3af3
to
d310788
Compare
This replaces direct eval in pyodide.asm.js with indirect eval, see comment in the commit.
danlapid
force-pushed
the
dlapid/fix_setupEmscripten_build_warnings
branch
from
d310788
to
6e8be63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces direct eval in pyodide.asm.js with indirect eval, see comment in the commit.