Python pools: Remove lockfile and indexURL arguments from getEmscriptenSettings #2935
+26
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
requested review from
harrishancock,
ObsidianMinor,
danlapid and
dom96
danlapid
approved these changes
Oct 16, 2024
…enSettings Instead, just pass `isWorkerd` and then set up lockfile and indexURL in python.ts
hoodmane
force-pushed
the
hoodmane/refactor-for-pools3
branch
from
282941c
to
9621149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, just pass
isWorkerdand then set up lockfile and indexURL in python.ts