Revert "Erikcorry roll v8 13.0 (#2918)" #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2160e96.
erikcorry
approved these changes
Oct 16, 2024
fhanau
reviewed
Oct 16, 2024
| @@ -22,9 +22,8 @@ class V8PlatformWrapper: public v8::Platform { | |||
| return inner.NumberOfWorkerThreads(); | |||
| } | |||
|
|
|||
| std::shared_ptr<v8::TaskRunner> GetForegroundTaskRunner( | |||
There was a problem hiding this comment.
Instead of repeatedly rolling this change back and forth, can't we just keep the update and use #if V8_MAJOR_VERSION >= 13 to select between both versions so that the internal build just works with either V8 release? Otherwise I have to recompile almost everything for workerd whenever we roll this back/reland it. Having a temporary version mismatch should be acceptable as long as it won't be for extended time frames.
There was a problem hiding this comment.
Is this something to be added now, or can it be added into the next attempt to reintroduce this change?
There was a problem hiding this comment.
If we had added it now, we would not have had to do the revert at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2160e96.