Support 'exceededMemory' error status #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdavidrodgers
requested review from
threepointone and
petebacondarwin
as code owners
🦋 Changeset detectedLatest commit: f2b07ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2820506372/npm-package-wrangler-1639You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1639/npm-package-wrangler-1639Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2820506372/npm-package-wrangler-1639 dev path/to/script.js |
Codecov Report
@@ Coverage Diff @@
## main #1639 +/- ##
=======================================
Coverage 81.84% 81.84%
=======================================
Files 89 89
Lines 5898 5900 +2
Branches 1510 1511 +1
=======================================
+ Hits 4827 4829 +2
Misses 1071 1071
|
While the exception for 'Worker exceeded memory limits' gets logged correctly when tailing, the actual status wasn't being counted as an error, and was falling through a switch case to 'unknown' This ensures filtering and logging reflects that status correctly
matthewdavidrodgers
force-pushed
the
exceeded-memory-status
branch
from
0cbd926
to
f2b07ed
Compare
Electroid
approved these changes
Aug 11, 2022
geelen
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the exception for 'Worker exceeded memory limits' gets logged
correctly when tailing, the actual status wasn't being counted as an
error, and was falling through a switch case to 'unknown'
This ensures filtering and logging reflects that status correctly