-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 feat: download of Worker script --from-dash
#1645
Conversation
🦋 Changeset detectedLatest commit: f514540 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2848647603/npm-package-wrangler-1645 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1645/npm-package-wrangler-1645 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2848647603/npm-package-wrangler-1645 dev path/to/script.js |
Codecov Report
@@ Coverage Diff @@
## main #1645 +/- ##
==========================================
- Coverage 81.37% 80.96% -0.42%
==========================================
Files 90 91 +1
Lines 5955 6062 +107
Branches 1527 1555 +28
==========================================
+ Hits 4846 4908 +62
- Misses 1109 1154 +45
|
1bad926
to
4aebb30
Compare
Video of functional testing, showing source code downloaded from dashboard of Screen.Recording.2022-08-10.at.2.01.59.PM.mov |
ad7c13a
to
19be735
Compare
--from-dash
19be735
to
30546db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Left a couple comments, but once those are addressed it looks good to me 👍🏻
Added `wrangler init --from-dash <worker-name>`, which allows initializing a wrangler project from a pre-existing worker in the dashboard. Resolves #1624 Discussion: #1623 Notes: `multiplart/form-data` parsing is [not currently supported in Undici](nodejs/undici#974), so a temporary workaround to slice off top and bottom boundaries is in place.
30546db
to
f514540
Compare
Workaround for handling multipart/form-data slicing off top and bottom boundaries.
multipart/formdata not supported currently in Undici nodejs/undici#974