Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Open browser button on windows #1670

Merged
merged 1 commit into from
Aug 12, 2022
Merged

fix: Open browser button on windows #1670

merged 1 commit into from
Aug 12, 2022

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Aug 12, 2022

Closes #1652

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2022

🦋 Changeset detected

Latest commit: 23dbc2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2848743029/npm-package-wrangler-1670

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1670/npm-package-wrangler-1670

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2848743029/npm-package-wrangler-1670 dev path/to/script.js

@JacobMGEvans
Copy link
Contributor

The test failing is from a flakey one.

@Skye-31
Copy link
Contributor Author

Skye-31 commented Aug 12, 2022

Retried, thanks!

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1670 (23dbc2f) into main (3785267) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1670   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files          91       91           
  Lines        6012     6012           
  Branches     1543     1543           
=======================================
  Hits         4875     4875           
  Misses       1137     1137           

@Skye-31 Skye-31 merged commit 1b232aa into main Aug 12, 2022
@Skye-31 Skye-31 deleted the fix-open-browser-windows branch August 12, 2022 19:04
This was referenced Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: default 0.0.0.0 wrangler dev address not routable in Windows
2 participants