Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [windows] unable to find netstat #1649

Merged
merged 2 commits into from
Aug 12, 2022
Merged

fix: [windows] unable to find netstat #1649

merged 2 commits into from
Aug 12, 2022

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Aug 10, 2022

Closes #1587

@Skye-31 Skye-31 added the pages Relating to Pages label Aug 10, 2022
@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022

🦋 Changeset detected

Latest commit: 7101336

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2839129907/npm-package-wrangler-1649

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1649/npm-package-wrangler-1649

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2839129907/npm-package-wrangler-1649 dev path/to/script.js

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1649 (7101336) into main (db592f0) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1649   +/-   ##
=======================================
  Coverage   81.60%   81.61%           
=======================================
  Files          89       89           
  Lines        5921     5922    +1     
  Branches     1520     1520           
=======================================
+ Hits         4832     4833    +1     
  Misses       1089     1089           
Impacted Files Coverage Δ
packages/wrangler/src/pages/dev.tsx 22.75% <33.33%> (-0.14%) ⬇️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@Skye-31 Skye-31 marked this pull request as draft August 11, 2022 10:10
@Skye-31 Skye-31 marked this pull request as ready for review August 11, 2022 10:30
Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Skye-31 Skye-31 merged commit a366b12 into main Aug 12, 2022
@Skye-31 Skye-31 deleted the fix-netstat-not-found branch August 12, 2022 16:48
This was referenced Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Relating to Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: [pages + windows] Could not automatically determine proxy port
2 participants