Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SW and Durable Object request URLs made over the service registry #1665

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

GregBrimble
Copy link
Member

A follow up to #1626

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2022

🦋 Changeset detected

Latest commit: 9609ac6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2842829360/npm-package-wrangler-1665

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1665/npm-package-wrangler-1665

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2842829360/npm-package-wrangler-1665 dev path/to/script.js

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1665 (9609ac6) into main (f650a0b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1665      +/-   ##
==========================================
+ Coverage   81.53%   81.54%   +0.01%     
==========================================
  Files          89       89              
  Lines        5924     5924              
  Branches     1521     1521              
==========================================
+ Hits         4830     4831       +1     
+ Misses       1094     1093       -1     
Impacted Files Coverage Δ
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Forgot to include those nice catch!

@GregBrimble GregBrimble merged commit c40fca4 into main Aug 11, 2022
@GregBrimble GregBrimble deleted the more-service-registry-pathname-fixes branch August 11, 2022 22:13
This was referenced Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants