Move BOSH release acceptance tests (brats) to src/
#2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramprice
force-pushed
the
move-brats-to-src-dir
branch
2 times, most recently
from
18c0f5b
to
e149e6d
Compare
aramprice
requested review from
a team,
xtreme-nitin-ravindran and
nader-ziada
and removed request for
a team
This completes the work of making this go code use the facilitlies introduced with `go.mod` which allows code to be placed independ of the codes source-control location (ex: src/github.com/cloudfoundry/bosh-release-acceptance-tests)
aramprice
force-pushed
the
move-brats-to-src-dir
branch
from
e149e6d
to
315d880
Compare
ystros
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
The BOSH release acceptance tests (brats) were authored before the existence of
go modand as such needed to be located in a SCM related directory structure (ex:src/github.com/cloudfoundry/...). This is no longer a requirement for Golang programs.This PR moves the code to a top-leve directory under
src/and slightly reorganizes the Golang packages in the "brats".What tests have you run against this PR?
Unit and
bratsspecs pass.How should this change be described in bosh release notes?
n/a
Does this PR introduce a breaking change?
No, there are only changes in the location of test files.