Add CPI method for native disk update #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain cloud providers offer the capability to modify disk attributes like IOPS and throughput directly, eliminating the need to create a new disk. To accommodate this, this change introduces a new CPI method called update_disk. Previously, adjusting disk properties required creating a new disk and transferring the data, a process that could be time-consuming for larger disks. Should the CPI not support this new method, BOSH will revert to the traditional approach of disk creation. Co-authored-by: MSSedusch <[email protected]>
This was referenced Aug 26, 2024
|
@s4heid, is this still in progress or is it ready for review? |
|
@jpalermo, it's ready for review, except for the integration tests which I couldn't set up locally, yet. |
|
Yeah, don't worry about the integration tests. We don't know how to run those either 😄 We can let CI take care of them once it's merged and fix anything that breaks. |
jpalermo
requested review from
a team,
lnguyen and
nader-ziada
and removed request for
a team
lnguyen
approved these changes
Sep 6, 2024
|
ping @nader-ziada regarding review. |
nader-ziada
approved these changes
Sep 23, 2024
|
it seems like this change may be breaking integration tests: There are similar failures for the non-hotswap integration suites. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Certain cloud providers offer the capability to modify disk attributes (e.g. IOPS and throughput) directly, eliminating the need to create a new disk. To accommodate this, this change introduces a new CPI method called
update_disk. Previously, adjusting disk properties required creating a new disk and transferring the data, a process that could be time-consuming for larger disks. Should the CPI not support this new method, BOSH will revert to the traditional approach of disk creation.Please provide contextual information.
What tests have you run against this PR?
update_diskI couldn't get the integration tests running on my system (yet).
How should this change be described in bosh release notes?
Enables direct update of disk properties through the Cloud Provider if supported, significantly speeding up large disk updates.
Does this PR introduce a breaking change?
No, this change is compatible with older versions.
Tag your pair, your PM, and/or team!
@MSSedusch