Pend invalid brats test (external db tls)

[aramprice]

These tests have been invalid since their creation. From the beginning they have passed certificate material in the director deployment manifest, however the director itself has (always?) expected to be passed paths to the certificates.

Original tests here:
f97c556#diff-ab90421945d114536b0c024f3cbaee7f4566c79a592ba9d46b395f0771745b42R293-R306

and

Director config here:

bosh/src/bosh-director/lib/bosh/director/config.rb

Lines 303 to 318 in c095b06

	certificate_paths = tls_options.fetch('cert')
	db_ca_path = certificate_paths.fetch('ca')
	db_client_cert_path = certificate_paths.fetch('certificate')
	db_client_private_key_path = certificate_paths.fetch('private_key')
	db_ca_provided = tls_options.fetch('bosh_internal').fetch('ca_provided')
	mutual_tls_enabled = tls_options.fetch('bosh_internal').fetch('mutual_tls_enabled')
	case connection_config['adapter']
	when 'mysql2'
	# http://sequel.jeremyevans.net/rdoc/files/doc/opening_databases_rdoc.html#label-mysql+
	connection_config['ssl_mode'] = tls_options.fetch('skip_host_verify', false) ? 'verify_ca' : 'verify_identity'
	connection_config['sslverify'] = true
	connection_config['sslca'] = db_ca_path if db_ca_provided
	connection_config['sslcert'] = db_client_cert_path if mutual_tls_enabled
	connection_config['sslkey'] = db_client_private_key_path if mutual_tls_enabled

[aramprice]

one-off brats run here: https://bosh.ci.cloudfoundry.org/teams/main/pipelines/bosh-director/jobs/pend-invalid-brats-delete/builds/1

[selzoc]

This branch seems to have a lot more than just pending the brats test - is that intentional?

[aramprice]

Yeah, I suppose that could be split out

The first set of commits were exploratory for understanding the problem (and adding some facilities for debugging this sort of thing in the future).

I am/was hesitant to simply pend the specs without supporting info/evidence.

That being said there are 3-4 commits which are purely cleanup that could likely be pushed separately.

¯_(ツ)_/¯

I collapsed some of the Golang fixups for clarity.