Gemfile and *.gemspec files are more honest #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramprice
force-pushed
the
gemfile-and-gemspecs-reflect-reality
branch
2 times, most recently
from
d62d449
to
7c2aef0
Compare
- move runtime dependencies into respective gemspec files - remove `:production` and `:bats` gem groups - ensure Gemfile has required `:development` / `:test` dependencies declared - move version locking to Gemfile so that it is controlled in one place
aramprice
force-pushed
the
gemfile-and-gemspecs-reflect-reality
branch
from
7c2aef0
to
1dfe2bf
Compare
aramprice
force-pushed
the
gemfile-and-gemspecs-reflect-reality
branch
from
1dfe2bf
to
a40e135
Compare
|
Successfully ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:productionand:batsgem groups:development/:testdependencies declared