Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow TLS provider v4 due to provider issue 244 #158

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Jul 25, 2022

what

  • Disallow hashicorp/tls provider version >= 4.0.0

why

When using hashicorp/tls provider v4.0.0 and setting oidc_provider_enabled = true on a new EKS cluster deployment, terraform plan will fail with thumbprint_list = [join("", data.tls_certificate.cluster.*.certficates.0.sha1_fingerprint)] and The given key does not identify an element in this collection value: the collection has no elements.

references

@Nuru Nuru requested review from a team as code owners July 25, 2022 03:05
@Nuru Nuru added the bugfix Change that restores intended behavior label Jul 25, 2022
@Nuru
Copy link
Contributor Author

Nuru commented Jul 25, 2022

/test all

@Nuru Nuru changed the title Disallow TLS provider v4 due to issue 244 Disallow TLS provider v4 due to provider issue 244 Jul 25, 2022
@Nuru
Copy link
Contributor Author

Nuru commented Jul 25, 2022

/test all

@Nuru Nuru merged commit d5a29cf into master Jul 25, 2022
@Nuru Nuru deleted the hotfix-oidc branch July 25, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Change that restores intended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant