-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Chat bubble #21
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 96.98% 99.21% +2.22%
==========================================
Files 16 19 +3
Lines 398 508 +110
Branches 26 63 +37
==========================================
+ Hits 386 504 +118
+ Misses 12 4 -8 ☔ View full report in Codecov by Sentry. |
src/chat-bubble/interfaces.ts
Outdated
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
export interface ChatBubbleProps { | ||
/** Avatar slot paired with the chat bubble. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we call "chat bubble" a message area only or the entire component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I mean the message area but if I say message area instead, not sure if it would be clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "Avatar slot paired with the chat bubble content"?
|
||
describe("Chat bubble", () => { | ||
afterEach(() => { | ||
cleanup(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what this cleanup is for?
Description
New chat bubble component
Related links, issue #, if available: AWSDesignSystem-462
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.