Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade visual resgression script to node 20 #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaeldowseza
Copy link
Member

@michaeldowseza michaeldowseza commented Oct 22, 2024

Description

Update actions node version to explicitly node version 20 as node 18 is out of active support.

Related links, issue #, if available: n/a

AWSUI-59859

How has this been tested?

PR checks make use of the code change. Can verify below.

image

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (ea82360) to head (fa99c2a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files          16       16           
  Lines         398      398           
  Branches       26       26           
=======================================
  Hits          386      386           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaeldowseza michaeldowseza marked this pull request as ready for review October 22, 2024 10:30
@michaeldowseza michaeldowseza requested a review from a team as a code owner October 22, 2024 10:30
@michaeldowseza michaeldowseza requested review from Al-Dani and removed request for a team October 22, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant