Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add focus visible logic from core #3

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

cansuaa
Copy link
Contributor

@cansuaa cansuaa commented Jun 17, 2024

Description

Moved the code from core repo. It is needed for avatar.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cansuaa cansuaa requested a review from a team as a code owner June 17, 2024 14:29
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.77%. Comparing base (b4e5bbb) to head (c99cc97).

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #3       +/-   ##
===========================================
+ Coverage   64.15%   96.77%   +32.62%     
===========================================
  Files          11       12        +1     
  Lines         159      217       +58     
  Branches       14       18        +4     
===========================================
+ Hits          102      210      +108     
+ Misses         54        7       -47     
+ Partials        3        0        -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jperals
Copy link
Member

jperals commented Jun 18, 2024

Why not move this code to component-toolkit instead of duplicating it?

pan-kot
pan-kot previously approved these changes Jun 18, 2024
@pan-kot
Copy link
Member

pan-kot commented Jun 18, 2024

Why not move this code to component-toolkit instead of duplicating it?

Let's create a follow-up task for this as adding the utilities to the toolkit requires more effort and adds significant delays as we need to wait for the new package version to be created.

gethinwebster
gethinwebster previously approved these changes Jun 19, 2024
@cansuaa cansuaa dismissed stale reviews from gethinwebster and pan-kot via 727a2a5 June 19, 2024 16:15
@cansuaa
Copy link
Contributor Author

cansuaa commented Jun 19, 2024

Why not move this code to component-toolkit instead of duplicating it?

Let's create a follow-up task for this as adding the utilities to the toolkit requires more effort and adds significant delays as we need to wait for the new package version to be created.

As discussed in slack, the task is created.

pan-kot
pan-kot previously approved these changes Jun 19, 2024
pan-kot
pan-kot previously approved these changes Jun 20, 2024
@cansuaa cansuaa merged commit 6d35f6c into main Jun 20, 2024
33 checks passed
@cansuaa cansuaa deleted the cansua/internal-focus-visible branch June 20, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants