feat: Property filter token groups #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 99.16% 99.17%
=======================================
Files 13 13
Lines 478 482 +4
Branches 168 170 +2
=======================================
+ Hits 474 478 +4
Misses 4 4 ☔ View full report in Codecov by Sentry. |
pan-kot
force-pushed
the
property-filter-token-groups
branch
4 times, most recently
from
ab0bdc9
to
e991757
Compare
pan-kot
changed the title
pan-kot
changed the title
pan-kot
changed the title
YueyingLu
reviewed
Aug 29, 2024
src/operations/property-filter.ts
Outdated
| return result; | ||
| return evaluate({ | ||
| operation: query.operation, | ||
| tokens: query.tokenGroups ?? query.tokens.map(token => ({ operation: 'and', tokens: [token] })), |
There was a problem hiding this comment.
Why is the operation always and but not token.operation?
There was a problem hiding this comment.
Great question. The query.tokens has type Token[] so no operation there. As the tokens list is always a single token the operation is irrelevant.
There was a problem hiding this comment.
I removed this transformation as unneeded as the evaluate function takes either token groups or tokens
pan-kot
force-pushed
the
property-filter-token-groups
branch
from
e991757
to
789cc7b
Compare
YueyingLu
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for token groups in property filter.
Property filter PR: cloudscape-design/components#2626
Rel: [qUFhApKfmWEg]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.