Skip to content

Commit

Permalink
Fix BaseTooltip.edit() signature (slab#3816)
Browse files Browse the repository at this point in the history
At the moment, the `BaseTooltip.edit()` signature has type:

```ts
declare class BaseTooltip extends Tooltip {
  edit(mode?: string, preview?: null): void;
}
```

This change tweaks the signature to be more accurate:

```ts
declare class BaseTooltip extends Tooltip {
  edit(mode?: string, preview?: string | null): void;
}
```
  • Loading branch information
alecgibson authored and luin committed Aug 7, 2023
1 parent 5bc1f52 commit 5a3f038
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion themes/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ class BaseTooltip extends Tooltip {
this.hide();
}

edit(mode = 'link', preview = null) {
edit(mode = 'link', preview: string | null = null) {
this.root.classList.remove('ql-hidden');
this.root.classList.add('ql-editing');
if (preview != null) {
Expand Down

0 comments on commit 5a3f038

Please sign in to comment.