Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node that receives focus should have tabindex="0" so that one can tab away and back to the data navigator #35

Closed
majornista opened this issue Jul 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@majornista
Copy link

At:

node.setAttribute('tabindex', '-1');

The node that receives focus within the data navigator currently has [tabindex="-1"], which means that should the user tab away from the data navigator, they can't shift+tab back to the focused node in the data navigator.

Use [tabindex="0"], so that the node that receives focus within the data navigator will be included in the tab navigation order for the web page.

@frankelavsky
Copy link
Contributor

Oh yeah, this is a great find and an easy fix! When I get a free moment, I'll change this over.

@frankelavsky frankelavsky added the bug Something isn't working label Jul 15, 2024
frankelavsky added a commit that referenced this issue Jul 15, 2024
…-have-tabindex=0-so-that-one-can-tab-away-and-back-to-the-data-navigator

node that receives focus should have tabindex=0 #35
@frankelavsky
Copy link
Contributor

Resolved in v1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants