Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescale image for playing round #66

Open
laurafulton opened this issue Apr 22, 2020 · 3 comments
Open

Rescale image for playing round #66

laurafulton opened this issue Apr 22, 2020 · 3 comments
Assignees

Comments

@laurafulton
Copy link
Contributor

Screen Shot 2020-04-22 at 12 17 24 PM

@kazijawad
Copy link

I just ran through the game with the pineapple and I'm not getting this problem. I tried rescaling and it still doesn't happen once. I checked the item and it has a margin-top applied to it.

@kazijawad
Copy link

So, I found the issue... It's a current issue in Safari with flex-box. It's happening because the height of the profiles class is a flex container and its using percentages. I'm not sure if I'll find time this week to fix the problem because of finals and this styling is in the old giant index.scss. Feel free to tackle it though if anyone has time!

@kazijawad
Copy link

To add onto the issue, I tried applying a static height to the container and that didn't fix the issue. So it most likely involves restructuring the original styles the previous members made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants