Allow Task and Execution roles as inputs #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to update Infracost job to use the latest actions because the one used is deprecated but looks like the |
amontalban
force-pushed
the
am/conditional_role_creation
branch
from
773f7fb
to
a46e6ed
Compare
|
Hey @jnonino 👋, Not sure what is the next step for this because I see it is assigned to me but I do not have the permission to merge it. Thanks! |
|
Hi, the changes look good to me, but if you can revert the change in the pipeline it would be better, I will check the infracost part later. |
amontalban
force-pushed
the
am/conditional_role_creation
branch
from
a46e6ed
to
f70bdfd
Compare
Gotcha, I have removed the Infracost commits. Thanks 🙏 ! |
jnonino
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the module to accept ECS Task Execution Role and ECS Task Role ARNs as input variables, disabling the creation of the
aws_iam_role.ecs_task_execution_roleresource and the custom policies.Additionally, I removed the
.terraform.lock.hclfiles and did some adjustments topre-commithooks.