Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileGlobs: Extract ignore globs from .npmignore file #109

Open
satwikkansal opened this issue Jun 11, 2017 · 6 comments
Open

FileGlobs: Extract ignore globs from .npmignore file #109

satwikkansal opened this issue Jun 11, 2017 · 6 comments
Assignees
@prachi1210
Labels
difficulty/low status/STALE

Comments

@satwikkansal
Copy link
Member

Some developers use .npmignore file to keep stuff out of their npm package. If there's no .npmignore file, but there is a .gitignore file, then npm will ignore the stuff matched by the .gitignore file.

Like git, npm looks for .npmignore and .gitignore files in all subdirectories of your package, not only the root directory. (There's an issue #108 for this functionality)

.npmignore files follow the same pattern rules as .gitignore files.

difficulty/low
@satwikkansal satwikkansal changed the title FileGlobs: Extract ignore from .npmignore file FileGlobs: Extract ignore globs from .npmignore file Jun 11, 2017
@prachi1210
Copy link
Member

Hi, I'd like to work on this issue.

@satwikkansal
Copy link
Member Author

satwikkansal commented Jun 19, 2017 via email

@prachi1210
Copy link
Member

prachi1210 commented Jul 3, 2017 •
edited
Loading

@satwikkansal just to clarify, do I need to recursively look for .npmignore files in all subdirs and extract globs

@satwikkansal
Copy link
Member Author

@prachi1210 yeah right. There's another PR for git ignore, you can take help from that ;)

@satwikkansal
Copy link
Member Author

Link to the PR: #110

prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Jul 4, 2017
@prachi1210
FileGlobs.py : Recursively extract .npmignore glob
5a661c8 
Looks for .npmignore in dirs and subdirs
recursively and extract file globs

Closes coala#109
@prachi1210 prachi1210 mentioned this issue Jul 4, 2017
Closed
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Jul 4, 2017
@prachi1210
FileGlobs.py : Recursively extract .npmignore glob
6067f4d 
Looks for .npmignore in dirs and subdirs
recursively and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Jul 4, 2017
@prachi1210
FileGlobs.py : Recursively extract .npmignore glob
1748c6d 
Looks for .npmignore in dirs and subdirs
recursively and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Jul 5, 2017
@prachi1210
FileGlobs.py : Recursively extract .npmignore glob
db012b4 
Looks for .npmignore in dirs and subdirs
recursively and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Jul 5, 2017
@prachi1210
FileGlobs.py : Recursively extract .npmignore glob
2a3a22b 
Looks for .npmignore in dirs and subdirs
recursively and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Jul 5, 2017
@prachi1210
FileGlobs.py : Recursively extract .npmignore glob
f3300a1 
Looks for .npmignore in dirs and subdirs
recursively and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Jul 5, 2017
@prachi1210
FileGlobs.py : Recursively extract .npmignore glob
644b1ca 
Looks for .npmignore in dirs and subdirs
recursively and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Jul 5, 2017
@prachi1210
FileGlobs.py : Recursively extract .npmignore glob
4607921 
Looks for .npmignore in dirs and subdirs
recursively and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 8, 2017
@prachi1210
FileGlobs.py : Recursively extract .npmignore glob
13e3d9c 
Looks for .npmignore in dirs and subdirs
recursively and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 8, 2017
@prachi1210
FileGlobs.py : Recursively extract .npmignore glob
a103939 
Looks for .npmignore in dirs and subdirs
recursively and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 8, 2017
@prachi1210
FileGlobs.py : Recursively extract .npmignore glob
1938561 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 8, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
02b878f 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
@prachi1210 prachi1210 mentioned this issue Aug 8, 2017
Open
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 8, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
7252f06 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 8, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
15ceebc 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 8, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
a559c33 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 16, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
fe9fd56 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 18, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
b41c6c4 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 18, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
92532e8 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 18, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
569e7ab 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 18, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
e9ecc9a 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 18, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
9236101 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 18, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
ac83598 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 18, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
e71d438 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 18, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
9cd63ea 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 18, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
f1b6ed5 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
prachi1210 added a commit to prachi1210/coala-quickstart that referenced this issue Aug 18, 2017
@prachi1210
FileGlobs.py: Recursively extract .npmignore globs
0ee49ab 
Looks for .npmignore in dirs and subdirs recursively
and extract file globs

Closes coala#109
@djmgit
Copy link
Contributor

djmgit commented Jun 8, 2018

@prachi1210 hi, are you still working on this? If not I would like to take this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prachi1210 prachi1210

Labels
difficulty/low status/STALE
Milestone
No milestone
Development

No branches or pull requests
4 participants
@satwikkansal @prachi1210 @gitmate-bot @djmgit