[RPC] Refactored sessions. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| auto it = mapping.find(channel_id); | ||
|
|
||
| // NOTE: Not sure if that can ever happen, but that's why people use asserts, right? | ||
| BOOST_ASSERT(it != mapping.end()); |
There was a problem hiding this comment.
We always disable asserts for some reasons. I suggest to drop this check https:/cocaine/cocaine-core/blob/v0.12/include/cocaine/common.hpp#L36
There was a problem hiding this comment.
Nah, let's keep it. I'd rather suggest make it on for CMAKE_BUILD_TYPE=Debug by default.
There was a problem hiding this comment.
Can you do it in a separate PR, since you know CMake better than me?
* Sessions no longer depend on `boost::signals2`. The shutdown signal wasn't required in the first place, since under highload system will reuse fds fast enough to replace stale sessions in the engine's map, and for quiet times engines will now garbage collect stale sessions every 60 seconds. * Sessions now log stuff. That means improvements over `uncaught_error` without any details about what error was not actually caught. * Much more predictable dispatch discard policy. Note that `discard()` call may or may not be accompanied by `std::error_code`.
kobolog
force-pushed
the
kobolog/refactor-sessions
branch
from
f91be71
to
2818f73
Compare
kobolog
force-pushed
the
kobolog/refactor-sessions
branch
from
2818f73
to
3eb9a49
Compare
antmat
pushed a commit
to antmat/cocaine-core
that referenced
this pull request
Jun 19, 2017
This commit adds additional bind method to the trace implementation that wraps the given function directly without intermediate `std::bind`.
3Hren
added a commit
that referenced
this pull request
Aug 18, 2017
This commit adds additional bind method to the trace implementation that wraps the given function directly without intermediate `std::bind`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/95HRjhQa
boost::signals2. The shutdown signal wasn't required in the first place, since under highload system will reuse fds fast enough to replace stale sessions in the engine's map, and for quiet times engines will now garbage collect stale sessions every 60 seconds.uncaught_errorwithout any details about what error was not actually caught.discard()call may or may not be accompanied bystd::error_code.