Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Use "Generic" variant for fedora-40 #6166

Merged

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented Apr 3, 2024

Just like we did for fedora-rawhide.

  • image-refresh fedora-40

Just like we did for fedora-rawhide.
@mvollmer mvollmer added the bot label Apr 3, 2024
@cockpituous cockpituous changed the title images: Use "Generic" variant for fedora-40 WIP: 874703180fea: [no-test] images: Use "Generic" variant for fedora-40 Apr 3, 2024
@mvollmer mvollmer mentioned this pull request Apr 3, 2024
1 task
@cockpituous
Copy link
Contributor

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 874703180fea: [no-test] images: Use "Generic" variant for fedora-40 images: Use "Generic" variant for fedora-40 Apr 3, 2024
@mvollmer mvollmer marked this pull request as ready for review April 3, 2024 08:54
jelly
jelly previously approved these changes Apr 3, 2024
@jelly jelly self-requested a review April 3, 2024 10:00
@jelly
Copy link
Member

jelly commented Apr 3, 2024

So this fixes #6143

But I see a new? stratis failure.

@mvollmer
Copy link
Member Author

mvollmer commented Apr 3, 2024

But I see a new? stratis failure.

Yeah, let's see... there are many reasons why rebooting might fail.

@martinpitt
Copy link
Member

@mvollmer maybe the same as in cockpit-project/cockpit#20245 ?

@mvollmer
Copy link
Member Author

mvollmer commented Apr 3, 2024

@mvollmer maybe the same as in cockpit-project/cockpit#20245 ?

Interesting! Thanks for the pointer.

@mvollmer
Copy link
Member Author

mvollmer commented Apr 3, 2024

But I see a new? stratis failure.

Yeah, let's see... there are many reasons why rebooting might fail.

stratis-storage/stratisd#3586

I make a naughty pattern for that.

@mvollmer
Copy link
Member Author

mvollmer commented Apr 3, 2024

@mvollmer maybe the same as in cockpit-project/cockpit#20245 ?

Yes, that also got stratisd 3.6.6, which has the bug.

The new f40 image has the bug already, and it's in update-testing for
f39.
@martinpitt
Copy link
Member

This machines failure is similar to issue #5979, but it crashes in a different place: udevInterfaceGetXMLDesc. That needs to be reported still.

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! I'll deal with the machines flake separately, that's not new.

@martinpitt martinpitt merged commit d195176 into cockpit-project:main Apr 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants