-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: migrate to go modules #35426
Comments
Thanks for your report! IT's a bit late to do this in the 19.1 release cycle, but we'll seriously consider this for 19.2 (the next one). |
I'd also love this - I'm trying to use |
Now that modules is considered stable on 1.14 maybe it's time to reactivate this. |
Can I help to migrate to go modules? |
You can certainly help! Just be aware that it's likely a relatively complex task. |
I want to. But I don't fill the power to lead this process) |
FYI the entire crdb team is currently busy with the upcoming 20.1 release and we won't be leading this either for a month or two. |
Ok! I'm ready to take part in this process |
I'd love to help you with this task! |
CRDB version 20.1 has been released. Adding go.mod and go.sum files to the root of the repository would be a good initial step. Google senior engineer Jean de Klerk, has authored a starting reference on how to approach the move to the official/standard approach to modularizing an existing codebase: https://blog.golang.org/migrating-to-go-modules |
At this time there is still a lot of work to be done due to the following:
|
Now that #34919 #33709 and cockroachdb/apd#83 got merged, it will be technically possible to replace
dep
in favor ofmodules
, so that tools vendorizingcockroachdb/cockroachdb-gen
(and using modules), could do this seemlessly.I got it working in:
https:/lopezator/sqlfmt/blob/master/go.mod
By forking
cockroach-gen
, and adding:https:/lopezator/cockroach/blob/master/go.mod
But it's an ugly hack that could be avoided if
cockroach && cockroach-gen
switches to go modules.The text was updated successfully, but these errors were encountered: