Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot use go mod #47246

Closed
nnsgmsone opened this issue Apr 9, 2020 · 2 comments
Closed

cannot use go mod #47246

nnsgmsone opened this issue Apr 9, 2020 · 2 comments
Assignees
Labels
C-investigation Further steps needed to qualify. C-label will change.

Comments

@nnsgmsone
Copy link

Describe the problem

I want to use go mod to refer to cockroach, but it failed. The error message is

"go/pkg/mod/github.com/cockroachdb/[email protected]+incompatible/pkg/util/tracing/shadow.go:48:12: undefined: zipkintracer.Collector"

To Reproduce

I tried to quote the cockroach package, this is part of my go mod file:

replace (
github.com/cockroachdb/apd => github.com/cockroachdb/apd/v2 v2.0.2-0.20190505045354-5843f9b6a583
go.etcd.io/etcd => go.etcd.io/etcd v0.5.0-alpha.5.0.20191113212143-63dd73c1869f
)

@awoods187 awoods187 added the C-investigation Further steps needed to qualify. C-label will change. label Apr 9, 2020
@bobvawter
Copy link
Member

Duplicate of #38824

@bobvawter bobvawter marked this as a duplicate of #38824 Apr 13, 2020
@charlesvdv
Copy link

I also stumbled on this issue when trying to import github.com/cockroachdb/cockroach/pkg/sql/parser. For future reference, here is the fix:

Add in your go.mod:

replace github.com/openzipkin-contrib/zipkin-go-opentracing => github.com/openzipkin-contrib/zipkin-go-opentracing v0.3.5

The problem comes from the fact that zipkin-go-opentracing has broken backward compatibility somewhere between v0.3.5 and v0.4.5 and for some reason (not a go module expert), the go module system is taking the v0.4.5 when cockroach uses the v0.3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-investigation Further steps needed to qualify. C-label will change.
Projects
None yet
Development

No branches or pull requests

4 participants