You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have an Experimental.KeyValidationFunc to validate keys but it is only used in one case (check compacted file bounds). We should promote this to a method on the Comparer and use it more, especially on API calls like Download, Compact, IngestExternalFiles, IngestAndExcise. It is preferable to error out a specific operation than letting an invalid key go through and then either crash later or do something incorrectly.
We have an
Experimental.KeyValidationFunc
to validate keys but it is only used in one case (check compacted file bounds). We should promote this to a method on theComparer
and use it more, especially on API calls likeDownload
,Compact
,IngestExternalFiles
,IngestAndExcise
. It is preferable to error out a specific operation than letting an invalid key go through and then either crash later or do something incorrectly.See cockroachdb/cockroach#128043 for a few cases where CRDB was passing keys that were not properly encoded.
Jira issue: PEBBLE-233
The text was updated successfully, but these errors were encountered: