Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis CI #237

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Fix Travis CI #237

merged 1 commit into from
Nov 26, 2019

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Nov 24, 2019

Minimal changes to make Travis CI work:

  • Ubuntu Xenial does not support PHP 5.4 and 5.5 and since it's the default environment we have to define Trusty in config
  • increase memory limit for composer
  • upgrading mockery to stable version to fix PHP Fatal error: Declaration of Mockery_2_Nette_DI_ServiceDefinition::__isset($name) must be compatible with Nette\DI\ServiceDefinition::__isset(string $name): bool in vendor/mockery/mockery/library/Mockery/Loader/EvalLoader.php(16) : eval()'d code on line 25

In separate PR:
composer self-update is made by Travis CI itself, no need to do it 2nd time
disabling Xdebug - not needed and slows down - especially 5.x - jobs
using Prestissimo to speed up jobs

@OskarStark
Copy link
Contributor

Could you please explain why this fixes Travis? Just for the record, thanks 👌🏻

@kubawerlos kubawerlos changed the title Fix Travis CI [WIP] Fix Travis CI Nov 24, 2019
@kubawerlos kubawerlos changed the title [WIP] Fix Travis CI Fix Travis CI Nov 25, 2019
@kubawerlos
Copy link
Contributor Author

@OskarStark Travis is green 🍾

@kubawerlos kubawerlos mentioned this pull request Nov 25, 2019
@florianeckerstorfer florianeckerstorfer merged commit ada8029 into cocur:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants