Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitignore cleanup #244

Merged
merged 1 commit into from
Dec 23, 2019
Merged

.gitignore cleanup #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
*.sublime-project
*.sublime-workspace
.idea
/vendor/
/.php_cs.cache
/nbproject/private/
/build/
/cache/
vendor
report
composer.lock
phpunit.xml
humbuglog.txt
/composer.lock
/phpunit.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe .dist and rename the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the question - we have .dist file and ignore phpunit.xml, what would you like to change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name it phpunit.xml.dist as it’s a best practice AFAIK and the ignore that file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't get it, what do you want to name phpunit.xml.dist?

AFAIK best practice is to have phpunit.xml.dist and ignore phpunit.xml - exactly what we have right now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are totallly right I mixed things up 😂 Christmas is coming... need to relax more 😉

2 changes: 2 additions & 0 deletions dev-tools/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/vendor/
/composer.lock