Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 4 bridge #32

Merged
merged 4 commits into from
Aug 24, 2014

Conversation

cviebrock
Copy link

Here's my contribution of a Laravel bridge for slugify.

I'm not 100% confident that I wrote the unit test properly. It seems to do what I want it to, and the tests pass, but there may be a "better" way to instantiate the Laravel application and load the service provider.

Thanks!

@florianeckerstorfer
Copy link
Member

Thanks for the PR, but I seems that Laraval does not work with PHP 5.3 which is still supported by this library. I have never worked with Laraval, any ideas how we can circumvent this?

@cviebrock
Copy link
Author

Laravel does work with PHP 5.3, at least the 4.1 release does. It could be that 4.2 doesn't. Let me see if I can adjust things to make it work with PHP 5.3.

@cviebrock
Copy link
Author

There you go. It'll work with Laravel 4.1, which runs under PHP 5.3. Laravel 4.0 requires an earlier version of symfony/http-kernel, but I didn't want to mess with that dependency.

@cviebrock
Copy link
Author

FYI, scrutinizer-ci.com takes a long time to run composer install. Would you consider using --prefer-dist instead of source in the YAML config?

@florianeckerstorfer florianeckerstorfer merged commit 35eac1c into cocur:master Aug 24, 2014
@florianeckerstorfer
Copy link
Member

Thank you for the PR and sorry that this took me that long to merge. To be honest I completely forgot about it.

In the future please try to use the coding style used throughout the project and to keep the code coverage at 100%. The knowledge that every single line of code has been executed during the test process gives me confidence that there are no typos or accidental characters in the PRs. Thanks you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants