Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add types to avoid PHP 8.2 deprecation warning #322

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

antoniovj1
Copy link

Hi team,

I wanted to let you know about a deprecation warning I've been getting in all my projects since updating to PHP 8.2. The warning is related to using nullable types instead of strings.

Here's the link to the PHP 8.1 deprecation notice: link

To address this, I think we should improve the types used in the slugify method, but it would be a breaking change.

Another option is to check for null at the beginning of the method and return an empty string in that case. However, I'm not sure if this is the best solution.

Please share your thoughts on whether this approach is correct or if you have any other ideas.

Thanks.

@florianeckerstorfer florianeckerstorfer merged commit 6ab49c8 into cocur:main Jul 31, 2023
@antoniovj1
Copy link
Author

Thanks!! @florianeckerstorfer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants