Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed empty return in top_meta_image #109

Merged
merged 1 commit into from
Feb 6, 2015
Merged

Conversation

0x0ece
Copy link
Contributor

@0x0ece 0x0ece commented Jan 15, 2015

Return empty unicode in ContentExtractor.top_meta_image() when no image is found. It was returning the article's url.

Example:
http://www.usnews.com/news/entertainment/articles/2015/01/15/boyhood-keaton-moore-are-oscar-favorites-in-vegas
(note that USNews often updates its articles, e.g. by adding an image -- at the time of writing it was without images)

Return empty unicode in ContentExtractor.top_meta_image() when no image is found. It was returning the article's url.

Example:
http://www.usnews.com/news/entertainment/articles/2015/01/15/boyhood-keaton-moore-are-oscar-favorites-in-vegas
(note that USNews often updates its articles, e.g. by adding an image -- at the time of writing it was without images)
@codelucas
Copy link
Owner

Nicely done, my only comment is that newspaper on master is a python 3 library, so return u'' should be return ''.

Don't worry about it though, I'll merge this on the command line and apply that tiny fix before the code goes in later today.

@0x0ece
Copy link
Contributor Author

0x0ece commented Jan 15, 2015

Ops, sorry about that and thank you!

@codelucas codelucas merged commit e408b86 into codelucas:master Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants