Parse byline fix #132
Merged
Parse byline fix #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 26, 2015 23:31
…r into parse-byline-fix
|
It looks like a test is failing, so I am closing this for now. Will re-open and include changes to tests after I've resolved it. |
|
👍 Thanks for the PR anyways, looking forward to the updated version |
|
Okay, I have made some more changes, including the tests. I modified the sample HTML file to include a more complex list of authors. The tests are passing, but please comment if you see any potential troubles with this approach. |
|
Merged finally, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a couple cases where the author was not getting extracted correctly:
This pull request addresses both of these issues. Thanks.