Support urls with dots #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexanderlukanin13 another great find! |
| return None | ||
| file_type = last_chunk[-1] | ||
| # Assume that file extension is maximum 5 characters long | ||
| if len(file_type) <= 5 or file_type.lower() in ALLOWED_TYPES: |
There was a problem hiding this comment.
Perhaps 5 should be defined in a constants file? Ugh, but it's not like the rest of this codebase set a good example
There was a problem hiding this comment.
@codelucas 5 is a quick-and-dirty heuristic, and it should be kept local. Moving it to constants would only give it an undeserved air of authority.
The proper solution is to use a extension blacklist and HEAD requests for uncertain cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a critical bug in
newspaper3k==0.1.5which prevents it from recognizing urls with dots in them.For example: http://www.enfieldindependent.co.uk/news/
Please upload a new version on PyPI if possible.